Time for a code audit?

[Ben Romer]

On Sat, 2016-02-13 at 01:01 +0300, Dan Carpenter wrote:
> I looked at the Smatch warnings, plus some bonus stuff I'm still
> working
> on.
> 
> drivers/staging/unisys/include/iochannel.h:592 add_physinfo_entries()
> warn: inconsistent indenting
> drivers/staging/unisys/include/iochannel.h:596 add_physinfo_entries()
> warn: inconsistent indenting
> drivers/staging/unisys/include/iochannel.h:600 add_physinfo_entries()
> warn: XXX should 'inp_pfn + i' be a 64 bit type?
> 

Hi Dan,

Thank you for this list! We'll get started on fixing these issues
immediately. I've run Smatch using the make options 

O=../builds/testbuild CC=gcc-4.9 CHECK="smatch -p=kernel" C=1

but when I use it this way, I don't get that line where it complains
about the variable's size. What settings do you use?

If I can generate a list of problems that way across the whole driver
set, we can just resolve them all without having to bother you or Greg
until we have patches for them.

Thanks a ton for the review. :) 

-- Ben