[PATCH 08/11] staging: wilc1000: change handle_set_channel's return type to void
Chaehyun Lim
chaehyun.lim at gmail.com
Fri Feb 12 14:04:44 UTC 2016
When handle_set_channel is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due
to have a single statement.
Signed-off-by: Chaehyun Lim <chaehyun.lim at gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index e9a6aa7..eecd697 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -299,8 +299,8 @@ static struct wilc_vif *wilc_get_vif_from_idx(struct wilc *wilc, int idx)
return wilc->vif[index];
}
-static s32 handle_set_channel(struct wilc_vif *vif,
- struct channel_attr *hif_set_ch)
+static void handle_set_channel(struct wilc_vif *vif,
+ struct channel_attr *hif_set_ch)
{
s32 result = 0;
struct wid wid;
@@ -313,12 +313,8 @@ static s32 handle_set_channel(struct wilc_vif *vif,
result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1,
wilc_get_vif_idx(vif));
- if (result) {
+ if (result)
PRINT_ER("Failed to set channel\n");
- return -EINVAL;
- }
-
- return result;
}
static s32 handle_set_wfi_drv_handler(struct wilc_vif *vif,
--
2.7.1
More information about the devel
mailing list