Staging: fbtft: add ssd1325 controller support

Dan Carpenter dan.carpenter at oracle.com
Fri Feb 12 07:27:23 UTC 2016


Hello Alexey Mednyy,

The patch 12e2a34165d5: "Staging: fbtft: add ssd1325 controller
support" from Jan 27, 2016, leads to the following static checker
warning:

	drivers/staging/fbtft/fb_ssd1325.c:100 blank()
	warn: passing __func__ while the format string already contains the name of the function 'blank'

drivers/staging/fbtft/fb_ssd1325.c
    98  static int blank(struct fbtft_par *par, bool on)
    99  {
   100          fbtft_par_dbg(DEBUG_BLANK, par, "%s(blank=%s)\n",
   101                        __func__, on ? "true" : "false");

blank(blank=true) is sort of duplicative, yes.

   102  
   103          if (on)
   104                  write_reg(par, 0xAE);
   105          else
   106                  write_reg(par, 0xAF);
   107          return 0;
   108  }

regards,
dan carpenter


More information about the devel mailing list