[PATCH] android/binder: fix fput comment

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sun Feb 7 22:54:51 UTC 2016


On Fri, Dec 25, 2015 at 09:47:17PM +0100, Jann Horn wrote:
> Just something I noticed while looking at FD-passing code.
> Didn't test the change.
> 
> BUG_ON is intentional, if someone rewrites the code to hit
> that, it can be a security issue.

Never add BUG to the kernel, you just crashed the machine and made it so
that the user lost their data without any idea of what happend :(

and if at all possible, please test your changes before sending them
out...

thanks,

greg k-h


More information about the devel mailing list