PATCH] drivers/staging/dgnc/dgnc_mgmt.c add some goto statements

Dan Carpenter dan.carpenter at oracle.com
Thu Dec 22 18:58:55 UTC 2016


On Thu, Dec 22, 2016 at 04:26:31PM +0000, Francis Laniel wrote:
> Le 2016-12-20 12:24, Dan Carpenter a écrit :
> >This patch doesn't apply.  Read Documentation/process/email-clients.rst
> >
> >On Tue, Dec 20, 2016 at 11:49:41AM +0100, Francis Laniel wrote:
> >>Hello.
> >>
> >>
> >>As asked in the TODO file for this driver I added some goto
> >>statements to
> >>handle errors.
> >>
> >>I used Linus Torvalds tree, I compiled it and tested it with a virtual
> >>machine, here is the proof :
> >>[   42.394265] dgnc: module is from the staging directory, ...
> >>[root at vm-nmv ~]# uname -r
> >>4.9.0-11815-ge93b1cc-dirty
> >>
> >>It is my first patch so I hope I did not break anything.
> >>
> >>
> >>Good bye and thank you.
> >
> >Don't put this stuff in the changelog text.
> >
> 
> Why do I not put this stuff in the changelog ? Is it because it does
> not give
> information about the changes ?
> 

Type 'git log' and count how many changes have "Good bye and thank you"
in them.

regards,
dan carpenter



More information about the devel mailing list