[PATCH 02/14] rtlwifi_new: Remove RT_TRACE messages that use DBG_EMERG

Larry Finger Larry.Finger at lwfinger.net
Sun Dec 11 15:31:16 UTC 2016


On 12/11/2016 04:50 AM, Joe Perches wrote:
> On Sat, 2016-12-10 at 23:44 -0600, Larry Finger wrote:
>> These messages are always logged and reprresent error conditions, thus
>> we can use pr_err().
>>
>> Signed-off-by: Larry Finger <Larry.Finger at lwfinger.net>
>> Cc: Ping-Ke Shih <pkshih at realtek.com>
>> ---
>>  drivers/net/wireless/realtek/rtlwifi/base.c  | 15 ++++-----
>>  drivers/net/wireless/realtek/rtlwifi/cam.c   | 14 +++------
>>  drivers/net/wireless/realtek/rtlwifi/core.c  | 21 +++++--------
>>  drivers/net/wireless/realtek/rtlwifi/debug.c |  9 ++----
>>  drivers/net/wireless/realtek/rtlwifi/debug.h |  2 +-
>>  drivers/net/wireless/realtek/rtlwifi/efuse.c |  3 +-
>>  drivers/net/wireless/realtek/rtlwifi/pci.c   | 36 ++++++++--------------
>>  drivers/net/wireless/realtek/rtlwifi/ps.c    |  3 +-
>>  drivers/net/wireless/realtek/rtlwifi/rc.c    |  3 +-
>>  drivers/net/wireless/realtek/rtlwifi/usb.c   | 46 +++++++++-------------------
>>  10 files changed, 53 insertions(+), 99 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> []
>> @@ -207,8 +207,7 @@ static void _rtl_init_hw_ht_capab(struct ieee80211_hw *hw,
>>  	 *highest supported RX rate
>>  	 */
>>  	if (rtlpriv->dm.supp_phymode_switch) {
>> -		RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
>> -			 "Support phy mode switch\n");
>> +		pr_err("rtlwifi: Support phy mode switch\n");
>
> I believe most all of these are already prefixed
> by the wifi.h that has a #define pr_fmt

Yes, I missed that. V2 will not include the module name.

Larry



More information about the devel mailing list