[PATCH 6/6] staging: comedi: ni_at_a2150.c: Fix checkpatch warning

Anson Jacob ansonjacob.aj at gmail.com
Thu Aug 25 16:09:23 UTC 2016


Thank you for your comments.

On Thu, Aug 25, 2016 at 06:47:08PM +0300, Andrey Utkin wrote:
> 
> > +#define CHANNEL_BITS(x)		((x) & 0x7)
> > +#define CHANNEL_MASK		0x7
> 
> No uniform alignment. Please get everything in a row.
> If it's hard or this part of driver is expected to have a lot of changes
> in near future, then I'd remove any whitespace over single space between
> name and value.
>

I didn't get your point in this case. Could you explain it.


More information about the devel mailing list