[PATCH 1/2] staging: android: ion: Do not BUG on handle client mismatch

Johanna A johanna-a at mjao.org
Tue Aug 23 21:12:48 UTC 2016


On Tue, Aug 23, 2016 at 02:00:06PM -0700, Laura Abbott wrote:
> It's pretty harsh because the users of Ion need a less than subtle hint
> that something is broken. From experience, warning and leaking memory
> just leads to a system that limps along and warnings that get ignored.
> At long as Ion is primarily used for Android, I think keeping the
> BUG makes sense. If Ion ever gets a large amount of use outside of
> Android, moving away from the bug would be appropriate.

Well, if Android users really are *that* ignorant of warning messages, I guess we'll keep the BUG_ON in ion_free. I'll refactor the patch to remove only the BUG_ON in ion_free_nolock as suggested.

Best Regards,
Johanna Abrahamsson


More information about the devel mailing list