[PATCH] staging: i4l: icn: fix memdup_user.cocci warnings

Fengguang Wu fengguang.wu at intel.com
Tue Aug 23 12:27:21 UTC 2016


On Mon, Aug 22, 2016 at 09:19:36PM -0400, Greg KH wrote:
>On Tue, Aug 23, 2016 at 08:36:58AM +0800, kbuild test robot wrote:
>> drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user
>>
>>  Use memdup_user rather than duplicating its implementation
>>  This is a little bit restricted to reduce false positives
>>
>> Generated by: scripts/coccinelle/api/memdup_user.cocci
>>
>> CC: Sudip Mukherjee <sudipm.mukherjee at gmail.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
>> ---
>>
>>  0 files changed
>>
>> rule starting on line 17: position variables or mixed modifs interfere with comm_assoc isobool (
>> (
>>
>> (
>> (unknown *to == NULL)
>>   >>> IS_ERR(rule starting on line 17:to)
>>
>> |
>> !unknown *to
>>   >>> IS_ERR(rule starting on line 17:to)
>>
>> )
>> |
>> (unknown *NULL == unknown *to)
>>   >>> IS_ERR(rule starting on line 17:to)
>>
>> ) || ...)
>
>There's no patch here, did something go wrong?

Yes, the above error messages look like problems in the cocci script.
CC Julia for possible inputs.

Hi Julia, here is the context of the problem:

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head:   f5a9a15f8fd4168e415e94f5dce367f3cef08e03
commit: ee05e5f7113ea0b0db7eff7011a534c92fec2648 [251/347] staging: i4l: icn: donot assign in if statement

coccinelle warnings: (new ones prefixed by >>)

>> drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user

Thanks,
Fengguang


More information about the devel mailing list