[PATCH 2/9] staging: most: hdm-usb: fix race between enqueue and most_stop_enqueue

Greg KH gregkh at linuxfoundation.org
Tue Aug 16 12:12:36 UTC 2016


On Tue, Aug 16, 2016 at 01:38:50PM +0200, Christian Gromm wrote:
> On Mon, 15 Aug 2016 20:39:38 +0200
> Greg KH <gregkh at linuxfoundation.org> wrote:
> 
> > On Mon, Jul 18, 2016 at 05:25:28PM +0200, Christian Gromm wrote:
> > > The "broken in pipe" handler of the USB-HDM calls most_stop_enqueue() to
> > > stop the MBO traffic before returning all MBOs back to the Mostcore.  As
> > > the enqueue() call from the Mostcore may run in parallel with the
> > > most_stop_enqueue(), the HDM may run into the inconsistent state and
> > > crash the kernel.
> > > 
> > > This patch synchronizes enqueue(), most_stop_enqueue() and
> > > most_resume_enqueue() with a mutex, hence avoiding the race condition.
> > > 
> > > Signed-off-by: Andrey Shvetsov <andrey.shvetsov at k2l.de>
> > > Signed-off-by: Christian Gromm <christian.gromm at microchip.com>
> > > ---
> > >  drivers/staging/most/hdm-usb/hdm_usb.c |  3 +-
> > >  drivers/staging/most/mostcore/core.c   | 53 ++++++++++++++++++++++++----------
> > >  2 files changed, 38 insertions(+), 18 deletions(-)
> > 
> > Doesn't apply to my tree anymore.  Can you fix this up and resend it and
> > the rest in this series so I can apply them?
> 
> According to git you didn't apply the patchset I sent in on Friday 6/17/16, did you?
> 
> 	>>> "[PATCH 0/9] staging: most: fix hdm-usb issues" <<<
> 
> Those patches need to be applied before the latest set.

All of the "staging: most:" patches are now applied to my tree, can you
sync up with it and resend anything reamaining?

thanks,

greg k-h


More information about the devel mailing list