[PATCH v2 08/10] staging: ks7010: Replace three printk() calls by pr_err()

SF Markus Elfring elfring at users.sourceforge.net
Thu Aug 11 05:48:00 UTC 2016


From: Markus Elfring <elfring at users.sourceforge.net>
Date: Wed, 10 Aug 2016 21:56:15 +0200

Prefer usage of the macro "pr_err" over the interface "printk".
Fix a typo in an error message.

Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
---
v2: Rebased on the source files from Linux next-20160809.

 drivers/staging/ks7010/ks7010_sdio.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 634ef42..bfca6a7 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -998,11 +998,11 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	/* private memory allocate */
 	netdev = alloc_etherdev(sizeof(*priv));
 	if (netdev == NULL) {
-		printk(KERN_ERR "ks7010 : Unable to alloc new net device\n");
+		pr_err(pr_fmt("Unable to alloc new net device\n"));
 		goto release_irq;
 	}
 	if (dev_alloc_name(netdev, "wlan%d") < 0) {
-		printk(KERN_ERR "ks7010 :  Couldn't get name!\n");
+		pr_err(pr_fmt("Couldn't get name!\n"));
 		goto free_dev;
 	}
 
@@ -1042,8 +1042,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	/* Upload firmware */
 	ret = ks7010_upload_firmware(priv, card);	/* firmware load */
 	if (ret) {
-		printk(KERN_ERR
-		       "ks7010: firmware load failed !! retern code = %d\n",
+		pr_err(pr_fmt("firmware load failed! return code = %d\n"),
 		       ret);
 		goto free_buf;
 	}
-- 
2.9.2



More information about the devel mailing list