drivers/staging/ks7010/ks_wlan_net.c:1287: suspicious if ?

David Binderman linuxdev.baldrick at gmail.com
Mon Aug 1 10:20:45 UTC 2016


Hello there,

drivers/staging/ks7010/ks_wlan_net.c:1287:13: warning: duplicated ‘if’
condition [-Wduplicated-cond]

Source code is

    } else if (enabled) {   /* 1 */
        if (priv->reg.operation_mode == MODE_INFRASTRUCTURE)
            priv->reg.powermgt = POWMGT_SAVE1_MODE;
        else
            return -EINVAL;
    } else if (enabled) {   /* 2 */

I am not sure of a suitable fix for this.

Regards

David Binderman


More information about the devel mailing list