[PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

YU Bo tsu.yubo at gmail.com
Wed Apr 27 13:27:39 UTC 2016


Fixed checkpatch.pl's warning 'Comparisons should place the constant on
the right side of the test'

Signed-off-by: YU Bo <tsu.yubo at gmail.com>
---
  drivers/staging/xgifb/vb_setmode.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4f5ab7..8bf253c224ad 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
  		if (pVBInfo->LCDInfo & EnableScalingLCD)
  			tempdx &= (~PanelResInfo);

-		if (table[i].PANELID == tempdx) {
+		if (tempdx == table[i].PANELID) {
  			tempbx = table[i].MASK;
  			tempdx = pVBInfo->LCDInfo;

@@ -3902,7 +3902,7 @@ static struct XGI301C_Tap4TimingStruct const

  	i = 0;
  	while (Tap4TimingPtr[i].DE != 0xFFFF) {
-		if (Tap4TimingPtr[i].DE == tempax)
+		if (tempax == Tap4TimingPtr[i].DE)
  			break;
  		i++;
  	}
--
1.7.10.4



More information about the devel mailing list