[PATCH v2 09/15] staging: comedi: mite: introduce mite_ack_linkc()

Ian Abbott abbotti at mev.co.uk
Thu Apr 21 09:25:24 UTC 2016


On 20/04/16 18:36, H Hartley Sweeten wrote:
> Introduce a helper function to handle the ack of a LINKC interrupt.
> Tidy up the drivers that use the new helper.
>
> The extra check for CHSR_INT in the ni_pcidio driver is not necessary.
> This bit will be set if any of the interrupt sources, including CHSR_LINKC,
> have generated an interrupt. Remove the extra check.
>
> The mite_get_status() function is now only used by the mite driver.
> Make it static and remove the export.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/mite.c          | 17 ++++++++++++++--
>   drivers/staging/comedi/drivers/mite.h          |  2 +-
>   drivers/staging/comedi/drivers/ni_mio_common.c | 28 +++++---------------------
>   drivers/staging/comedi/drivers/ni_pcidio.c     | 10 ++-------
>   drivers/staging/comedi/drivers/ni_tiocmd.c     | 13 +++---------
>   5 files changed, 26 insertions(+), 44 deletions(-)

Thanks!

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

(The other patches already have my "Reviewed-by".)
-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list