[PATCH 00/15] staging: comedi: mite: cleanup driver
Ian Abbott
abbotti at mev.co.uk
Tue Apr 19 10:32:25 UTC 2016
On 18/04/16 21:28, H Hartley Sweeten wrote:
> Fix all the checkpatch.pl issues and tidy up this driver.
>
> H Hartley Sweeten (15):
> staging: comedi: mite: Prefer 'unsigned int' to bare use of 'unsigned'
> staging: comedi: mite: remove TOP_OF_PAGE() macro
> staging: comedi: mite: remove mite_dma_tcr()
> staging: comedi: mite: don't export internal functions
> staging: comedi: mite: remove mite_struct member 'mite_phys_addr'
> staging: comedi: mite: remove mite_struct member 'daq_phys_addr'
> staging: comedi: ni_pcidio: remove redundant mite disarm/reset
> staging: comedi: mite: don't expose mite_dma_reset()
> staging: comedi: mite: introduce mite_ack_linkc()
> staging: comedi: mite: don't expose unnecessary register/bit info
> staging: comedi: mite: introduce mite_sync_dma()
> staging: comedi: mite: rename CamelCase CHSR bit enums
> staging: comedi: mite: document the mite_struct spinlock_t
> staging: comedi: mite: remove BUG_ON() in MITE_IODWBSR_1_WSIZE_bits()
> staging: comedi: mite: cleanup remaining mite register/bits
>
> drivers/staging/comedi/drivers/mite.c | 281 +++++++++++++++++------
> drivers/staging/comedi/drivers/mite.h | 302 +++++--------------------
> drivers/staging/comedi/drivers/ni_660x.c | 2 +-
> drivers/staging/comedi/drivers/ni_mio_common.c | 34 +--
> drivers/staging/comedi/drivers/ni_pcidio.c | 16 +-
> drivers/staging/comedi/drivers/ni_pcimio.c | 6 +-
> drivers/staging/comedi/drivers/ni_tiocmd.c | 11 +-
> 7 files changed, 282 insertions(+), 370 deletions(-)
>
Thanks. Looks OK apart from a definite bug plus a possible bug in PATCH 09.
For patches 01-08, 10-15...
Reviewed-by: Ian Abbott <abbotti at mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti at mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
More information about the devel
mailing list