[PATCH 00/19] staging: comedi: ni_mio_common: initial cleanup

H Hartley Sweeten hsweeten at visionengravers.com
Tue Apr 12 21:12:43 UTC 2016


This "driver" is is bit of a mess. It's included by the ni_atmio, ni_mio_cs,
and ni_pcimio drivers instead of being a separate module.

Do some cleanup so I can work out what is needed to make it a module.

This fixes all the checkpatch.pl issues except for two:
CHECK: if this code is redundant consider removing it

I left those in until I can figure out if they can be removed.

H Hartley Sweeten (19):
  staging: comedi: ni_mio_common: remove some unnecessary BUG_ON()
  staging: comedi: ni_mio_common: tidy up mite dma channel requests
  staging: comedi: ni_mio_common: tidy up mite dma channel releases
  staging: comedi: ni_mio_common: tidy up DIO subdevice ifdef'ery
  staging: comedi: ni_mio_common: Prefer 'unsigned int' to bare use of 'unsigned'
  staging: comedi: ni_mio_common: use 'unsigned int' instead of kernel types
  staging: comedi: ni_mio_common: tidy up block comments
  staging: comedi: ni_mio_common: fix lines over 80 characters
  staging: comedi: ni_mio_common: multiple assignments should be avoided
  staging: comedi: ni_mio_common: fix logical continuations
  staging: comedi: ni_mio_common: convert NI_GPCT_SUBDEV to a macro
  staging: comedi: ni_mio_common: tidy up AO trigger selection
  staging: comedi: ni_mio_common: tidy up AO scan begin
  staging: comedi: ni_mio_common: tidy up ni_gpct_write_register()
  staging: comedi: ni_mio_common: usleep_range is preferred over udelay
  staging: comedi: ni_mio_common: remove 'fudge_factor_80_to_20Mhz'
  staging: comedi: ni_mio_common: fix CamelCase in ni_serial_hw_readwrite8()
  staging: comedi: mite.h: rename CHSR_LxERR_mask
  staging: comedi: ni_mio_common: introduce NI_STC_DMA_CHAN_SEL()

 drivers/staging/comedi/drivers/mite.h          |   2 +-
 drivers/staging/comedi/drivers/ni_mio_common.c | 860 ++++++++++++-------------
 drivers/staging/comedi/drivers/ni_stc.h        |   1 -
 3 files changed, 402 insertions(+), 461 deletions(-)

-- 
2.6.3



More information about the devel mailing list