[PATCH 0/6] staging: sm750fb: remove dead code
Mike Rapoport
mike.rapoport at gmail.com
Wed Sep 30 05:24:53 UTC 2015
Hi,
These patches remove some functions and macros that are never used in the
sm750fb driver.
There is still lots of dead code, for instance, the driver compiles without
ddk750_sii.o and ddk750_dvi.o. These two seem required to enable particular DVI
transmitter and, apparently, they should not be a part of framebuffer driver.
More generally, sm750 chip has several sub-devices, such as GPIO, PWM and SPI
controllers, so I think it's worth considering converting the driver to base
MFD driver that creates the sub-devices and a framebuffer driver for the
graphics controller.
Mike Rapoport (6):
staging: sm750fb: staticize local functions in ddk750_chip
staging: sm750fb: remove unused calcPllValue2 function
staging: sm750fb: remove unused ddk750_initDVIDisp function
staging: sm750fb: remove unused macros
staging: sm750fb: staticize getPowerMode function
staging: sm750fb: remove unused enable{ZVPort,SSP,PWM} functions
drivers/staging/sm750fb/ddk750_chip.c | 112 ++-----------------------------
drivers/staging/sm750fb/ddk750_chip.h | 6 --
drivers/staging/sm750fb/ddk750_display.c | 33 ---------
drivers/staging/sm750fb/ddk750_display.h | 1 -
drivers/staging/sm750fb/ddk750_power.c | 63 +----------------
drivers/staging/sm750fb/ddk750_power.h | 17 -----
drivers/staging/sm750fb/sm750.h | 7 --
drivers/staging/sm750fb/sm750_help.h | 33 ---------
8 files changed, 7 insertions(+), 265 deletions(-)
--
2.1.0
More information about the devel
mailing list