[PATCH 04/37] staging/lustre: tracefile: use 64-bit seconds

Arnd Bergmann arnd at arndb.de
Fri Sep 25 10:17:18 UTC 2015


On Friday 25 September 2015 01:52:37 Drokin, Oleg wrote:
> On Sep 24, 2015, at 3:46 AM, Arnd Bergmann wrote:
> > On Thursday 24 September 2015 04:02:09 Drokin, Oleg wrote:
> These are all the users.
> Seems to be pretty much u32 (or unsigned int when printing) everywhere.

Ok, I'll the patch then to clarify this and leave the format unchanged.
 
> > Another option would be to change the code storing the times there
> > to do:
> > 
> >       header->ph_sec = (u32)ts.tv_sec;
> >       header->ph_usec = (ts.tv_sec & 0xffffffff00000000ull) | 
> >                          (ts.tv_nsec / NSEC_PER_USEC);
> > 
> > and do the reverse on the user space side. This would be both endian-
> > safe and backwards compatible, although rather ugly.
> 
> Indeed, thats' quite ugly.
> I think in the next 90 years we will need some other adjustments to the
> log format and should be able to include this one with them
> (e.g. there are only 16 bits for the cpu, considering we have 260+ core
> CPUs on the market today, might as well overflow that quite soon).

Ok.

	Arnd


More information about the devel mailing list