[PATCH 01/37] staging/lustre: use jiffies for lp_last_query times

Arnd Bergmann arnd at arndb.de
Wed Sep 23 19:13:24 UTC 2015


The recently introduced lnet_peer_set_alive() function uses
get_seconds() to read the current time into a shared variable,
but all other uses of that variable compare it to jiffies values.

This changes the current use to jiffies as well for consistency.

This likely changes behavior, and should be reviewed by the folks
that reviewed the original patch that introduced the unusual behavior
and was itself a bug fix.

Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Fixes: af3fa7c71bf ("staging/lustre/lnet: peer aliveness status and NI status")
Cc: Liang Zhen <liang.zhen at intel.com>
Cc: James Simmons <uja.ornl at gmail.com>
Cc: Isaac Huang <he.huang at intel.com>
Cc: Oleg Drokin <oleg.drokin at intel.com>
---
 drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
index 22d54b209528..b61d5045a566 100644
--- a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
+++ b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
@@ -680,7 +680,7 @@ void lnet_debug_peer(lnet_nid_t nid);
 static inline void
 lnet_peer_set_alive(lnet_peer_t *lp)
 {
-	lp->lp_last_alive = lp->lp_last_query = get_seconds();
+	lp->lp_last_alive = lp->lp_last_query = jiffies;
 	if (!lp->lp_alive)
 		lnet_notify_locked(lp, 0, 1, lp->lp_last_alive);
 }
-- 
2.1.0.rc2



More information about the devel mailing list