[PATCH v4] staging: unisys: Add s-Par visorhba

Greg KH gregkh at linuxfoundation.org
Wed Sep 23 17:00:06 UTC 2015


On Wed, Sep 23, 2015 at 12:38:06PM -0400, Benjamin Romer wrote:
> From: David Kershner <david.kershner at unisys.com>
> 
> This driver create a host bus adapter device when s-Par sends a
> device create message to create a storage adapter on the visorbus.
> When the message is received by visorbus, the visorhba_probe function
> is called and the hba device is created and managed by the visorhba
> driver.
> 
> Signed-off-by: Erik Arfvidson <erik.arfvidson at unisys.com>
> Signed-off-by: Benjamin Romer <benjamin.romer at unisys.com>
> Signed-off-by: David Kershner <david.kershner at unisys.com>
> 
> ---
> 
> v2:
> * address comments from Greg, Jes, Dan, and David Milburn
> 
> v3:
> * address additional issues from Red Hat

These are the least helpful "this is what changed" list I have ever seen
:(

> v4:
> * remove all BUG() and BUG_ON() - do not crash the kernel

You just deleted them?  No taking into account that you should just
handle issues like this in a run-time-safe way instead?

Come on, always respond to code reviews directly, don't just throw a new
patch at the problem otherwise it feels like I'm reviewing into a black
hole...

greg k-h


More information about the devel mailing list