[PATCH 001/192] staging: rtl8192e: Rename rtl8192_init

[Mateusz Kulikowski]

Hi Greg,

On Sun, Sep 20, 2015 at 07:09:48PM -0700, Greg KH wrote:
> On Sun, Sep 20, 2015 at 10:09:22AM +0200, Mateusz Kulikowski wrote:
[...]
> _ as a prefix for a function name?  That's horrid, and is not something
> we want to do in the kernel.
I agree, but it was not my convention.

> 
> Ick, that's what the drivers/net/wireless/rtlwifi/ drivers do.  Hm, are
> you really thinking you can clean this driver up enough to merge it into
> that portion of the kernel?  I think the naming of the functions is the
> least of the problems / worries here, why did you choose this task to do
> first?
To be honest - I'm not sure (yet) but I try to go in that direction. 
Next patches that I have rework firmware loading code (a bit) - 
they are not yet cleaned up for submission though.

After that I will probably either focus on PHY or start adapting functions to
rtlwifi requirements (i.e. interfaces).

I'm a bit afraid of doing big changes in "core" parts of the driver as 
I don't have fancy test infrastructure (I'm not able to test for example 
802.11a or mesh configurations). I also need to gather more domain knowledge 
before doing it (i.e. learn about wifi on RF/standard level).

I'm aware it's staging driver, but I prefer not to break it :)

Reasons why now:
- I did it for 'global' functions and there were no complaints:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-July/073163.html
due to holidays/work reasons I was not able to post it together.
- I have all the scripts/infrastructure needed to do the job
- It has to be done at some point (it's one of TODO points)
- It makes code more readable (searches are easier, function names are unique)


If you insist - we can drop it - just let me know so I will repost next 
series that depends on this changeset.

Mateusz