[PATCH 000/192] staging: rtl8192e: Fix static function names
Mateusz Kulikowski
mateusz.kulikowski at gmail.com
Sun Sep 20 08:09:21 UTC 2015
This somewhat large series cleans names of all static functions
in rtl8192e driver (excluding rtllib).
Naming convention similar to other rtlwifi cards was used -
functions are prefixed with _rtl92e_
Apart from standardizing, each function was inspected and some names
were changed to:
- make naming coherent in driver (ex. use irq not interrupt, irq, Interrupt)
- make name shorter
- reflect function body better
Most of the patches do just name swap, with possible exceptions:
- Function may be re-indented (i.e. arguments are moved around)
- Some extra whitespaces in changed line are removed
etc.
This series causes several checkpatch warnings and checks.
- all CAMELCASE checks should be ignored - camelcase is widely used
for variable names in driver
- There are two long-line warnings (patches #46 and #188) - I left them as
forcibly fixing would look awkward
- In patch #68 indentation of function arguments was not changed -
it look pretty well and otherwise would break 80-char boundary
Every patch in series was compile-tested.
Full target-test was performed on final patch in series.
I didn't checked each separate patch as they don't change driver logic/code.
Series should apply cleanly to current staging-next (0063fdfb1) and
staging-testing (3a8c41b5)
Mateusz Kulikowski (192):
staging: rtl8192e: Rename rtl8192_init
staging: rtl8192e: Rename rtl8192_init_priv_constant
staging: rtl8192e: Rename rtl8192_init_priv_handler
staging: rtl8192e: Rename rtl8192_init_priv_lock
staging: rtl8192e: Rename rtl8192_init_priv_task
staging: rtl8192e: Rename rtl8192_init_priv_variable
staging: rtl8192e: Rename rtl8192_interrupt
staging: rtl8192e: Rename rtl8192_irq_rx_tasklet
staging: rtl8192e: Rename rtl8192_irq_tx_tasklet
staging: rtl8192e: Rename rtl8192_ioctl
staging: rtl8192e: Rename rtl8192_open
staging: rtl8192e: Rename rtl8192_close
staging: rtl8192e: Rename rtl8192_down
staging: rtl8192e: Rename rtl8192_restart
staging: rtl8192e: Rename rtl8192_up
staging: rtl8192e: Rename _rtl8192_up
staging: rtl8192e: Rename rtl8192_pci_disconnect
staging: rtl8192e: Rename rtl8192_pci_initdescring
staging: rtl8192e: Rename rtl8192_pci_module_exit
staging: rtl8192e: Rename rtl8192_pci_module_init
staging: rtl8192e: Rename rtl8192_pci_probe
staging: rtl8192e: Rename rtl8192_alloc_rx_desc_ring
staging: rtl8192e: Rename rtl8192_alloc_tx_desc_ring
staging: rtl8192e: Rename rtl8192_free_rx_ring
staging: rtl8192e: Rename rtl8192_free_tx_ring
staging: rtl8192e: Rename rtl8192_tx
staging: rtl8192e: Rename rtl8192_tx_cmd
staging: rtl8192e: Rename rtl8192_tx_isr
staging: rtl8192e: Rename rtl8192_tx_timeout
staging: rtl8192e: Rename rtl8192_tx_resume
staging: rtl8192e: Rename rtl8192_is_tx_queue_empty
staging: rtl8192e: Rename rtl819x_TxCheckStuck
staging: rtl8192e: Rename rtl8192_rx_normal
staging: rtl8192e: Rename rtl819x_RxCheckStuck
staging: rtl8192e: Rename HwRateToMRate90
staging: rtl8192e: Rename MRateToHwRate8190Pci
staging: rtl8192e: Rename CPUcheck_firmware_ready
staging: rtl8192e: Rename CPUcheck_maincodeok_turnonCPU
staging: rtl8192e: Rename fw_download_code
staging: rtl8192e: Rename phy_FwRFSerialRead
staging: rtl8192e: Rename phy_FwRFSerialWrite
staging: rtl8192e: Rename rtl8192_phyConfigBB
staging: rtl8192e: Rename rtl8192_phy_FinishSwChnlNow
staging: rtl8192e: Rename rtl8192_phy_RFSerialRead
staging: rtl8192e: Rename rtl8192_phy_RFSerialWrite
staging: rtl8192e: Rename rtl8192_phy_SetSwChnlCmdArray
staging: rtl8192e: Rename rtl8192_phy_SwChnlStepByStep
staging: rtl8192e: Rename rtl8192_SwChnl_WorkItem
staging: rtl8192e: Rename rtl8192_prepare_beacon
staging: rtl8192e: Rename rtl8192_qos_activate
staging: rtl8192e: Rename rtl8192_qos_association_resp
staging: rtl8192e: Rename rtl8192_qos_handle_probe_response
staging: rtl8192e: Rename rtl8192_refresh_supportrate
staging: rtl8192e: Rename rtl8192_set_chan
staging: rtl8192e: Rename rtl8192_sta_down
staging: rtl8192e: Rename _rtl8192_sta_up
staging: rtl8192e: Rename rtl8192_stop_beacon
staging: rtl8192e: Rename rtl8192_update_beacon
staging: rtl8192e: Rename rtl8192_update_cap
staging: rtl8192e: Rename rtl819x_ifcheck_resetornot
staging: rtl8192e: Rename rtl819x_ifsilentreset
staging: rtl8192e: Rename rtl819x_silentreset_mesh_bk
staging: rtl8192e: Rename rtl819x_update_rxcounts
staging: rtl8192e: Rename rtl819x_watchdog_wqcallback
staging: rtl8192e: Rename watch_dog_timer_callback
staging: rtl8192e: Rename rtl8192_get_channel_map
staging: rtl8192e: Rename rtl8192_getSupportedWireleeMode
staging: rtl8192e: Rename rtl8192_handle_assoc_response
staging: rtl8192e: Rename rtl8192_handle_beacon
staging: rtl8192e: Rename rtl8192_hard_data_xmit
staging: rtl8192e: Rename rtl8192_hard_start_xmit
staging: rtl8192e: Rename rtl8192e_update_msr
staging: rtl8192e: Rename rtl8192_hwconfig
staging: rtl8192e: Rename rtl8192_MapHwQueueToFirmwareQueue
staging: rtl8192e: Rename rtl8192_net_update
staging: rtl8192e: Rename rtl8192_process_phyinfo
staging: rtl8192e: Rename rtl8192_QueryIsShort
staging: rtl8192e: Rename rtl8192_query_rxphystatus
staging: rtl8192e: Rename rtl8192_read_eeprom_info
staging: rtl8192e: Rename rtl8192_signal_scale_mapping
staging: rtl8192e: Rename rtl8192_TranslateRxSignalStuff
staging: rtl8192e: Rename
rtl8192_UpdateReceivedRateHistogramStatistics
staging: rtl8192e: Rename CCK_Tx_Power_Track_BW_Switch
staging: rtl8192e: Rename CCK_Tx_Power_Track_BW_Switch_ThermalMeter
staging: rtl8192e: Rename CCK_Tx_Power_Track_BW_Switch_TSSI
staging: rtl8192e: Rename rtl8192_BB_Config_ParaFile
staging: rtl8192e: Rename rtl8192_CalculateBitShift
staging: rtl8192e: Rename rtl8192_InitBBRFRegDef
staging: rtl8192e: Rename rtl8192_SetBWModeWorkItem
staging: rtl8192e: Rename rtl8192_SetTxPowerLevel
staging: rtl8192e: Rename SetRFPowerState8190
staging: rtl8192e: Rename r8192_set_mac_adr
staging: rtl8192e: Rename r8192_set_multicast
staging: rtl8192e: Rename rtl8192_cancel_deferred_work
staging: rtl8192e: Rename rtl8192_check_nic_enough_desc
staging: rtl8192e: Rename rtl819x_ethtool_get_drvinfo
staging: rtl8192e: Rename rtl819x_ethtool_get_link
staging: rtl8192e: Rename r8192_wx_adapter_power_status
staging: rtl8192e: Rename r8192_wx_force_reset
staging: rtl8192e: Rename r8192_wx_get_enc
staging: rtl8192e: Rename r8192_wx_get_essid
staging: rtl8192e: Rename r8192_wx_get_frag
staging: rtl8192e: Rename r8192_wx_get_freq
staging: rtl8192e: Rename r8192_wx_get_gen_ie
staging: rtl8192e: Rename r8192_wx_get_mode
staging: rtl8192e: Rename r8192_wx_get_name
staging: rtl8192e: Rename r8192_wx_get_nick
staging: rtl8192e: Rename r8192_wx_get_power
staging: rtl8192e: Rename r8192_wx_get_PromiscuousMode
staging: rtl8192e: Rename r8192_wx_get_rate
staging: rtl8192e: Rename r8192_wx_get_retry
staging: rtl8192e: Rename r8192_wx_get_rts
staging: rtl8192e: Rename r8192_wx_get_scan
staging: rtl8192e: Rename r8192_wx_get_sens
staging: rtl8192e: Rename r8192_wx_get_wap
staging: rtl8192e: Rename r8192_wx_set_auth
staging: rtl8192e: Rename r8192_wx_set_debugflag
staging: rtl8192e: Rename r8192_wx_set_enc_ext
staging: rtl8192e: Rename r8192_wx_set_essid
staging: rtl8192e: Rename r8192_wx_set_frag
staging: rtl8192e: Rename r8192_wx_set_freq
staging: rtl8192e: Rename r8192_wx_set_gen_ie
staging: rtl8192e: Rename r8192_wx_set_mlme
staging: rtl8192e: Rename r8192_wx_set_mode
staging: rtl8192e: Rename r8192_wx_set_nick
staging: rtl8192e: Rename r8192_wx_set_power
staging: rtl8192e: Rename r8192_wx_set_PromiscuousMode
staging: rtl8192e: Rename r8192_wx_set_rate
staging: rtl8192e: Rename r8192_wx_set_rawtx
staging: rtl8192e: Rename r8192_wx_set_retry
staging: rtl8192e: Rename r8192_wx_set_rts
staging: rtl8192e: Rename r8192_wx_set_scan
staging: rtl8192e: Rename r8192_wx_set_scan_type
staging: rtl8192e: Rename r8192_wx_set_sens
staging: rtl8192e: Rename r8192_wx_set_wap
staging: rtl8192e: Rename rtl8192_wx_get_range
staging: rtl8192e: Rename rtl8192_parse_pci_configuration
staging: rtl8192e: Rename InactivePsWorkItemCallback
staging: rtl8192e: Rename MgntActSet_802_11_PowerSaveMode
staging: rtl8192e: Rename rtl8192_hw_sleep_down
staging: rtl8192e: Rename r8192_get_wireless_stats
staging: rtl8192e: Rename r8192se_wx_set_force_lps
staging: rtl8192e: Rename r8192se_wx_set_lps_awake_interval
staging: rtl8192e: Rename dm_bandwidth_autoswitch
staging: rtl8192e: Rename dm_bb_initialgain_backup
staging: rtl8192e: Rename dm_bb_initialgain_restore
staging: rtl8192e: Rename dm_CCKTxPowerAdjust_ThermalMeter
staging: rtl8192e: Rename dm_CCKTxPowerAdjust_TSSI
staging: rtl8192e: Rename dm_check_ac_dc_power
staging: rtl8192e: Rename dm_check_edca_turbo
staging: rtl8192e: Rename dm_check_fsync
staging: rtl8192e: Rename dm_check_pbc_gpio
staging: rtl8192e: Rename dm_check_rate_adaptive
staging: rtl8192e: Rename dm_CheckRfCtrlGPIO
staging: rtl8192e: Rename dm_check_rx_path_selection
staging: rtl8192e: Rename dm_check_txpower_tracking
staging: rtl8192e: Rename dm_CheckTXPowerTracking_ThermalMeter
staging: rtl8192e: Rename dm_CheckTXPowerTracking_TSSI
staging: rtl8192e: Rename dm_check_txrateandretrycount
staging: rtl8192e: Rename dm_cs_ratio
staging: rtl8192e: Rename dm_ctrl_initgain_byrssi_by_driverrssi
staging: rtl8192e: Rename dm_ctrl_initgain_byrssi_by_fwfalse_alarm
staging: rtl8192e: Rename dm_ctrl_initgain_byrssi_highpwr
staging: rtl8192e: Rename dm_ctstoself
staging: rtl8192e: Rename dm_deInit_fsync
staging: rtl8192e: Rename dm_dig_init
staging: rtl8192e: Rename dm_dynamic_txpower
staging: rtl8192e: Rename dm_EndHWFsync
staging: rtl8192e: Rename dm_EndSWFsync
staging: rtl8192e: Rename dm_fsync_timer_callback
staging: rtl8192e: Rename dm_init_bandwidth_autoswitch
staging: rtl8192e: Rename dm_init_ctstoself
staging: rtl8192e: Rename dm_init_dynamic_txpower
staging: rtl8192e: Rename dm_init_fsync
staging: rtl8192e: Rename dm_initial_gain
staging: rtl8192e: Rename dm_InitializeTXPowerTracking_ThermalMeter
staging: rtl8192e: Rename dm_init_rxpath_selection
staging: rtl8192e: Rename dm_InitializeTXPowerTracking_TSSI
staging: rtl8192e: Rename dm_Init_WA_Broadcom_IOT
staging: rtl8192e: Rename dm_pd_th
staging: rtl8192e: Rename dm_rxpath_sel_byrssi
staging: rtl8192e: Rename dm_send_rssi_tofw
staging: rtl8192e: Rename dm_StartHWFsync
staging: rtl8192e: Rename dm_StartSWFsync
staging: rtl8192e: Rename dm_txpower_reset_recovery
staging: rtl8192e: Rename dm_TXPowerTrackingCallback_ThermalMeter
staging: rtl8192e: Rename dm_TXPowerTrackingCallback_TSSI
staging: rtl8192e: Rename dm_tx_update_tssi_strong_signal
staging: rtl8192e: Rename dm_tx_update_tssi_weak_signal
staging: rtl8192e: Rename r8192_wx_set_enc
staging: rtl8192e: Rename firmware_check_ready
staging: rtl8192e: Rename dm_ctrl_initgain_byrssi
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 82 +++--
.../staging/rtl8192e/rtl8192e/r8192E_firmware.c | 26 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 223 +++++++-------
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 331 ++++++++++-----------
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 282 +++++++++---------
drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c | 10 +-
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 4 +-
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 27 +-
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 329 ++++++++++----------
9 files changed, 662 insertions(+), 652 deletions(-)
--
1.8.4.1
More information about the devel
mailing list