[PATCH] IB/hfi1: fix sdma_descq_cnt parameter parsing

Mike Marciniszyn mike.marciniszyn at intel.com
Tue Sep 15 14:19:27 UTC 2015


The boolean tests should have been or-ed.

Reported-by: David Binderman <dcb314 at hotmail.com>
Reviewed-by: Jubin John <jubin.john at intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn at intel.com>
---
 drivers/staging/rdma/hfi1/sdma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c
index a8c903c..7e01f30 100644
--- a/drivers/staging/rdma/hfi1/sdma.c
+++ b/drivers/staging/rdma/hfi1/sdma.c
@@ -737,7 +737,7 @@ u16 sdma_get_descq_cnt(void)
 	 */
 	if (!is_power_of_2(count))
 		return SDMA_DESCQ_CNT;
-	if (count < 64 && count > 32768)
+	if (count < 64 || count > 32768)
 		return SDMA_DESCQ_CNT;
 	return count;
 }



More information about the devel mailing list