[PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK

Greg KH gregkh at linuxfoundation.org
Tue Sep 15 13:45:07 UTC 2015


On Tue, Sep 15, 2015 at 11:53:36AM +0900, Tony Cho wrote:
> From: Leo Kim <leo.kim at atmel.com>
> 
> This patch removes the definition WILC_NULLCHECK which is not used anymore.

No, it is used, you just remove all usages of it in this patch as well
:)

Also, your fixes are not correct, you are not keeping the same codepaths
here anymore, you are returning and not jumping to the ERRORHANDLER: tag
anymore, which could mean you are leaking memory.  Please fix up this
series and resend, but note, I took the first patch here.

thanks,

greg k-h


More information about the devel mailing list