[PATCH 00/13] staging: wilc1000: remove WILC_CATCH and friends

Mike Rapoport mike.rapoport at gmail.com
Tue Sep 15 13:44:04 UTC 2015


On Tue, Sep 15, 2015 at 4:32 PM, Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
> On Mon, Sep 14, 2015 at 10:00:42PM +0300, Mike Rapoport wrote:
>> Hi,
>>
>> These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK,
>> WILC_NULLCHECK and WILC_CATCH by plain code that either returns the error
>> value or sets the error code and uses goto to jump to error handling code.
>
> As Sudip said, you can't have a patch that adds a build warning, and
> then fix it up on later patches, each patch needs to be "stand alone"
> and work just fine as-is, with no dependancy on later patches.
>
> Please rework this series.

sent v2 already

> thanks,
>
> greg k-h



-- 
Sincerely yours,
Mike.


More information about the devel mailing list