[PATCH 1/2] Staging: lustre: libcfs: Use pr_info and pr_warn macros

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Sep 14 14:32:45 UTC 2015


On Mon, Sep 14, 2015 at 07:54:30PM +0530, Shraddha Barke wrote:
> 
> 
> On Mon, 14 Sep 2015, Greg Kroah-Hartman wrote:
> 
> >On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote:
> >>Replace all occurrences of  printk(KERN_* by pr_info and pr_warn macros.
> >>
> >>Build tested it.
> >
> >Why put this here in the changelog area?  You always have to at least
> >build test your changes, so this is always implied.
> 
> Yes I'll take it off in this and future patches.
> 
> >
> >And can some of these be changed to be dev_* calls instead?
> 
> Since there is no network device pointer in this function, isn't pr_*
> preferred?

dev_* is not just for network drivers.

And I don't know, look at the rest of the code for hints as to what to
use, don't just blindly convert code without looking at it first...


More information about the devel mailing list