[PATCH 1/2] Staging: lustre: libcfs: Use pr_info and pr_warn macros

Shraddha Barke shraddha.6596 at gmail.com
Mon Sep 14 14:24:30 UTC 2015



On Mon, 14 Sep 2015, Greg Kroah-Hartman wrote:

> On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote:
>> Replace all occurrences of  printk(KERN_* by pr_info and pr_warn macros.
>>
>> Build tested it.
>
> Why put this here in the changelog area?  You always have to at least
> build test your changes, so this is always implied.

Yes I'll take it off in this and future patches.

>
> And can some of these be changed to be dev_* calls instead?

Since there is no network device pointer in this function, isn't pr_* 
preferred?

Thanks,

Shraddha

>
> thanks,
>
> greg k-h
>


More information about the devel mailing list