[PATCH 1/2] staging: dgap: fix possible NULL dereference
Sudip Mukherjee
sudipm.mukherjee at gmail.com
Thu Sep 10 11:54:58 UTC 2015
The return pointer from dgap_getword() is used in strcmp() where it is
dereferenced. But dgap_getword() can return NULL.
Lets put a check there and return 0 as error.
Signed-off-by: Sudip Mukherjee <sudip at vectorindia.org>
---
drivers/staging/dgap/dgap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 9112dd2..20ba258 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -349,6 +349,8 @@ static int dgap_gettok(char **in)
if (strstr(dgap_cword, "board")) {
w = dgap_getword(in);
+ if (!w)
+ return 0;
snprintf(dgap_cword, MAXCWORD, "%s", w);
for (t = dgap_brdtype; t->token != 0; t++) {
if (!strcmp(w, t->string))
--
1.9.1
More information about the devel
mailing list