[PATCH 1/4] staging: wilc1000: remove kmalloc wrapper

Tony Cho tony.cho at atmel.com
Thu Sep 10 01:41:33 UTC 2015



On 2015년 09월 10일 03:17, Greg KH wrote:
> On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote:
>> From: Glen Lee <glen.lee at atmel.com>
>>
>> Call kmalloc directly. No need to wrap kmalloc.
>> Only one function, wilc_mq_send which use WILC_MALLOC, can be running in
>> interrupt context or process context. In this case, We call in_interrupt to
>> decide the flag, GFP_ATOMIC or GFP_KERNEL, for kmalloc properly. Additionally,
>> there is one kmalloc which flag is always GFP_ATOMIC. This also changed
>> together.
>> Others are not holding a spin lock or in interrupt context. So use GFP_KERNEL
>> flag for kmalloc.
>>
>> Signed-off-by: Glen Lee <glen.lee at atmel.com>
>> Signed-off-by: Tony Cho <tony.cho at atmel.com>
>> ---
>>   drivers/staging/wilc1000/host_interface.c         | 110 +++++++++++-----------
>>   drivers/staging/wilc1000/linux_wlan.c             |   2 +-
>>   drivers/staging/wilc1000/wilc_msgqueue.c          |  10 +-
>>   drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |  38 ++++----
>>   4 files changed, 83 insertions(+), 77 deletions(-)
> This no longer applies to my staging-testing branch, can you rebase it
> and resend it and the other patches in this series?
>
> thanks,
>
> greg k-h

I will resend this patch with Kconfig with BROKEN removed.

Thanks,
Tony.




More information about the devel mailing list