[PATCH v2 5/5] staging/wilc100 : Use BIT() macro where possible

Greg KH gregkh at linuxfoundation.org
Wed Sep 9 17:37:45 UTC 2015


On Fri, Sep 04, 2015 at 02:00:33PM -0700, Anish Bhatt wrote:
> Replace (1 << x) by BIT(x) as recommended by
> checkpatch.pl. Fix any resultant build warnings.
> 
> Signed-off-by: Anish Bhatt <anish at chelsio.com>
> ---
>  drivers/staging/wilc1000/wilc_wlan.c | 72 ++++++++++++++++++------------------
>  1 file changed, 35 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
> index 4b37de5..7397aa2 100644
> --- a/drivers/staging/wilc1000/wilc_wlan.c
> +++ b/drivers/staging/wilc1000/wilc_wlan.c
> @@ -305,9 +305,6 @@ typedef struct {
>  struct Ack_session_info *Free_head;
>  struct Ack_session_info *Alloc_head;
>  
> -#define TCP_FIN_MASK		(1 << 0)
> -#define TCP_SYN_MASK		(1 << 1)
> -#define TCP_Ack_MASK		(1 << 4)

This isn't "replace", it's "delete".  Please fix up.



More information about the devel mailing list