[PATCH 3/5] staging: wilc1000: use id value as argument

johnny.kim johnny.kim at atmel.com
Thu Sep 3 07:00:08 UTC 2015


Hello Greg.

On 2015년 09월 03일 10:33, Greg KH wrote:
> On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote:
>> From: Johnny Kim <johnny.kim at atmel.com>
>>
>> The driver communicates with the chipset via the address of handlers
>> to distinguish async data frame. The SendConfigPkt function gets the
>> pointer address indicating the handlers as the last argument, but this
>> requires redundant typecasting and does not support the 64 bit machine.
>>
>> This patch adds the function which assigns ID values instead of pointer
>> representing the driver handler to the address and then uses the ID
>> instead of pointer as the last argument of SendConfigPkt. The driver
>> also gets the handler's address from the ID in the data frame when it
>> receives them.
>>
> I don't understand this code at all.  You are randomly adding values to
> a list, and then assuming that you can use the index into that list for
> some type of representation?  As this is a local list, why not just use
> the real variables instead of having a list and dealing with them in
> this very ackward manner?
>
> In other words, I don't see the need for the list at all, just use the
> real types here, you have all the needed information (hint, if you know
> the index, you really know the data as well...)
>
The value is needed to send it to chipset and to distinguish async data 
packet
mutually. The length of the data field is 4byte and the data field has been
filled with the address of pointer so far.
But this patch changes it to unique index value corresponding to the address
for 64bit address machine. If real type is used as your opinion, new 
patch will
have the same meaning with current code.

Thanks
Johnny.



More information about the devel mailing list