[PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

[Brüns, Stefan]

On Tuesday, September 01, 2015 16:57:14 Noralf Trønnes wrote:
> > 
> > IMHO, this is a bad idea. A controller supporting more than 32 bpw can
> > not set the bpw mask, as the mask is limited to 32 bits. Thus it has to
> > check the bpw in its own setup function, and may or may not reject 9 bpw.
> > 
> > Why should one penalize any controllers having an unset bpw mask, which
> > is a completely valid configuration?
> > 
> > BTW, the SPI core patch needed for this to work is in the 4.3 pull
> > request.
> 
> I have acked a patch from Stefan Wahren adressing this issue:
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-Augus
> t/075423.html

Two issues:

1st: Stefan Wahren posted a patch large part identical to mine, 18 hours 
later. Coincidence?

2nd: Modifying bpw and not calling spi_setup() is IMHO wrong. The controller 
setup function could e.g. modify max_speed_hz.

Regards,

Stefan

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034     mobile: +49 151 50412019
work: +49 2405 49936-424