[PATCH 17/17] staging: wilc1000: wilc_netdev_init: use wilc instead of g_linux_wlan

glen lee glen.lee at atmel.com
Fri Oct 30 08:50:03 UTC 2015



On 2015년 10월 30일 17:35, Dan Carpenter wrote:
> On Fri, Oct 30, 2015 at 12:10:42PM +0900, Glen Lee wrote:
>>   	/*create the common structure*/
>> -	g_linux_wlan = kzalloc(sizeof(*g_linux_wlan), GFP_KERNEL);
>> -	if (!g_linux_wlan)
>> +	wl = kzalloc(sizeof(struct wilc), GFP_KERNEL);
> This introduces a checkpatch.pl warning.  The prefered style is:
>
> 	wl = kzalloc(sizeof(*wl), GFP_KERNEL);
>
> But the larger point is that please use checkpatch.pl.

Thank you for the review, I will use preferred style in v2.

regards,

glen lee

>
> regards,
> dan carpenter
>



More information about the devel mailing list