[PATCH 17/17] staging: wilc1000: wilc_netdev_init: use wilc instead of g_linux_wlan

Dan Carpenter dan.carpenter at oracle.com
Fri Oct 30 08:35:44 UTC 2015


On Fri, Oct 30, 2015 at 12:10:42PM +0900, Glen Lee wrote:
>  	/*create the common structure*/
> -	g_linux_wlan = kzalloc(sizeof(*g_linux_wlan), GFP_KERNEL);
> -	if (!g_linux_wlan)
> +	wl = kzalloc(sizeof(struct wilc), GFP_KERNEL);

This introduces a checkpatch.pl warning.  The prefered style is:

	wl = kzalloc(sizeof(*wl), GFP_KERNEL);

But the larger point is that please use checkpatch.pl.

regards,
dan carpenter



More information about the devel mailing list