[PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

Haiyang Zhang haiyangz at microsoft.com
Wed Oct 28 17:59:50 UTC 2015



> -----Original Message-----
> From: Richard Weinberger [mailto:richard.weinberger at gmail.com]
> Sent: Tuesday, October 27, 2015 6:36 PM
> To: David Miller <davem at davemloft.net>
> Cc: Haiyang Zhang <haiyangz at microsoft.com>; olaf at aepfle.de; Greg Kroah-
> Hartman <greg at kroah.com>; netdev at vger.kernel.org;
> jasowang at redhat.com; driverdev-devel at linuxdriverproject.org; LKML
> <linux-kernel at vger.kernel.org>
> Subject: Re: [PATCH net-next] hyperv: Add handler for
> RNDIS_STATUS_NETWORK_CHANGE event
> 
> On Mon, Jun 23, 2014 at 10:10 PM, David Miller <davem at davemloft.net>
> wrote:
> > From: Haiyang Zhang <haiyangz at microsoft.com>
> > Date: Mon, 23 Jun 2014 16:09:59 +0000
> >
> >> So, what's the equivalent or similar command to "network restart" on
> >> SLES12? Could you update the command line for the usermodehelper
> when
> >> porting this patch to SLES 12?
> >
> > No, you are not going to keep the usermodehelper invocation in your
> > driver please remove it.  It is absolutely inappropriate, and I
> > strictly do not want to keep it in there because other people will
> > copy it and then we'll have a real mess on our hands.
> 
> Sorry for digging up this old thread.
> While talking with some guys about usermodehelper abuses I came across
> this gem.
> Mainline still contains that "/etc/init.d/network restart" code.
> Haiyang, care to cleanup?

I will clean up the usermode helper soon.

Thanks,
- Haiyang



More information about the devel mailing list