[RESEND PATCH v2 4/5] staging: lustre: selftest.h: replace IS_PO2 by is_power_of_2

Sudip Mukherjee sudipm.mukherjee at gmail.com
Wed Oct 28 06:44:57 UTC 2015


On Tue, Oct 27, 2015 at 07:45:22PM +0200, Aya Mahfouz wrote:
> Replaces IS_PO2 by is_power_of_2. It is more accurate to use
> is_power_of_2 since it returns 1 for numbers that are powers
> of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
> powers of 2.
> 
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal at gmail.com>
> ---
> v2:
>         -added new patch in patch set for selftest.h
> 
>  drivers/staging/lustre/lnet/selftest/selftest.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/selftest.h b/drivers/staging/lustre/lnet/selftest/selftest.h
> index 8a77d3f..2846f26 100644
> --- a/drivers/staging/lustre/lnet/selftest/selftest.h
> +++ b/drivers/staging/lustre/lnet/selftest/selftest.h
> @@ -43,6 +43,8 @@
>  
>  #define LNET_ONLY
>  
> +#include <linux/log2.h>
> +
>  #include "../../include/linux/libcfs/libcfs.h"
>  #include "../../include/linux/lnet/lnet.h"
>  #include "../../include/linux/lnet/lib-lnet.h"
> @@ -585,7 +587,7 @@ swi_state2str (int state)
>  do {									\
>  	int __I = 2;							\
>  	while (!(cond)) {						\
> -		CDEBUG(IS_PO2(++__I) ? D_WARNING : D_NET,		\
> +		CDEBUG(is_power_of_2(++__I) ? D_WARNING : D_NET,		\

An extra tab here broke the alignent of those '\'.

regards
sudip


More information about the devel mailing list