[PATCH 5/5] staging: sm750fb: use direct call to hw_sm750_output_setMode
Mike Rapoport
mike.rapoport at gmail.com
Fri Oct 23 14:55:11 UTC 2015
The proc_setMode method in lynx_output always uses the same
implementation and there is no point to use redirection rather than
direct function call.
Signed-off-by: Mike Rapoport <mike.rapoport at gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 +---
drivers/staging/sm750fb/sm750.h | 4 ----
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 24c4f39..cd20629 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -386,7 +386,7 @@ static int lynxfb_ops_set_par(struct fb_info *info)
}
ret = hw_sm750_crtc_setMode(crtc, var, fix);
if (!ret)
- ret = output->proc_setMode(output, var, fix);
+ ret = hw_sm750_output_setMode(output, var, fix);
return ret;
}
@@ -674,8 +674,6 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
crtc->ypanstep = 1;
crtc->ywrapstep = 0;
- output->proc_setMode = hw_sm750_output_setMode;
-
output->proc_setBLANK = (share->revid == SM750LE_REVISION_ID) ?
hw_sm750le_setBLANK : hw_sm750_setBLANK;
/* chip specific phase */
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 6f5e09d..bf905aa 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -125,10 +125,6 @@ struct lynxfb_output {
*/
void *priv;
- int (*proc_setMode)(struct lynxfb_output*,
- struct fb_var_screeninfo*,
- struct fb_fix_screeninfo*);
-
int (*proc_setBLANK)(struct lynxfb_output*, int);
};
--
2.1.0
More information about the devel
mailing list