[PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

Tony Cho tony.cho at atmel.com
Fri Oct 23 08:13:05 UTC 2015



On 2015년 10월 23일 16:52, Dan Carpenter wrote:
> On Fri, Oct 23, 2015 at 04:36:07PM +0900, Tony Cho wrote:
>> In addition, the function parameter names will be wilc
>> for the variable of struct wilc.
>>
>> The "wl" is local variable naming as well.
> So if it is a parameter it is wilc but if it is a local variable then it
> is wl?  That seems like an arbitrary meaningless distinction.  It just
> makes searching harder and complicates things for no reason.

I will be on the business trip for the time being so let me ask Glen to

reconsider your concerns to apply your opinion to coming patches.

I always appreciate your guide and reviews because learning valuable things from you.

Thanks,

Tony.

>
> regards,
> dan carpenter
>



More information about the devel mailing list