[PATCH 16/16] staging: rtl8192e: _rtl92e_fw_boot_cpu: Remove unneeded goto

Mateusz Kulikowski mateusz.kulikowski at gmail.com
Mon Oct 19 20:00:30 UTC 2015


Drop ugly label as no resource cleanup is needed.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski at gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index becf062..9aaa855 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -38,7 +38,7 @@ static bool _rtl92e_fw_boot_cpu(struct net_device *dev)
 
 	if (!_rtl92e_wait_for_fw(dev, CPU_GEN_PUT_CODE_OK, 200)) {
 		netdev_err(dev, "Firmware download failed.\n");
-		goto CPUCheckMainCodeOKAndTurnOnCPU_Fail;
+		return false;
 	}
 	netdev_dbg(dev, "Download Firmware: Put code ok!\n");
 
@@ -49,15 +49,12 @@ static bool _rtl92e_fw_boot_cpu(struct net_device *dev)
 
 	if (!_rtl92e_wait_for_fw(dev, CPU_GEN_BOOT_RDY, 200)) {
 		netdev_err(dev, "Firmware boot failed.\n");
-		goto CPUCheckMainCodeOKAndTurnOnCPU_Fail;
+		return false;
 	}
 
 	netdev_dbg(dev, "Download Firmware: Boot ready!\n");
 
 	return true;
-
-CPUCheckMainCodeOKAndTurnOnCPU_Fail:
-	return false;
 }
 
 static bool _rtl92e_fw_check_ready(struct net_device *dev,
-- 
2.1.4



More information about the devel mailing list