[PATCH 00/45] staging: comedi: cb_pcidas: cleanup driver

[Ian Abbott]

On 14/10/15 01:47, H Hartley Sweeten wrote:
> Following is the big cleanup of the comedi cb_pcidas driver.
>
> H Hartley Sweeten (45):
>    staging: comedi: cb_pcidas: tidy up multi-line comments
>    staging: comedi: cb_pcidas: remove NUM_CHANNELS_* defines
>    staging: comedi: cb_pcidas: refactor 'ai_bits' boardinfo
>    staging: comedi: cb_pcidas: refactor analog output boardinfo
>    staging: comedi: cb_pcidas: all boards have 16 analog input channels
>    staging: comedi: cb_pcidas: refactor 'ranges' boardinfo
>    staging: comedi: cb_pcidas: rename private data 'control_status'
>    staging: comedi: cb_pcidas: rename private data 'adc_fifo'
>    staging: comedi: cb_pcidas: rename private data 'ao_registers'
>    staging: comedi: cb_pcidas: tidy up PCI BAR4 register defines
>    staging: comedi: cb_pcidas: use comedi_range_is_unipolar()
>    staging: comedi: cb_pcidas: tidy up PCI BAR3 register defines
>    staging: comedi: cb_pcidas: tidy up PCI BAR2 register defines
>    staging: comedi: cb_pcidas: convert inline DAC bit helpers to macros
>    staging: comedi: cb_pcidas: tidy up interrupt/ADC FIFO register
>    staging: comedi: cb_pcidas: tidy up ADC mux/control register
>    staging: comedi: cb_pcidas: tidy up trigger control/status register
>    staging: comedi: cb_pcidas: tidy up calibration register
>    staging: comedi: cb_pcidas: tidy up DAC control/status register
>    staging: comedi: cb_pcidas: use preferred kernel types
>    staging: comedi: cb_pcidas: tidy up calibration trimpot subdevice
>    staging: comedi: cb_pcidas: tidy up trimpot_7376_write()
>    staging: comedi: cb_pcidas: tidy up trimpot_8402_write()
>    staging: comedi: cb_pcidas: tidy up caldac_8800_write()
>    staging: comedi: cb_pcidas: refactor write_calibration_bitstream()
>    staging: comedi: cb_pcidas: absorb caldac/trimpot write functions
>    staging: comedi: cb_pcidas: tidy up cb_pcidas_trimpot_write()
>    staging: comedi: cb_pcidas: refactor 'trimpot' boardinfo
>    staging: comedi: cb_pcidas: tidy up dac08 calibration subdevice
>    staging: comedi: cb_pcidas: tidy up dac08_write()
>    staging: comedi: cb_pcidas: tidy up 8800 caldac calibration subdevice
>    staging: comedi: cb_pcidas: tidy up memory subdevice init
>    staging: comedi: cb_pcidas: fix cb_pcidas_eeprom_insn_read()
>    staging: comedi: cb_pcidas: rename private data 's5933_config'
>    staging: comedi: cb_pcidas: rename private data 's5933_intcsr_bits'
>    staging: comedi: cb_pcidas: tidy up analog output subdevice init
>    staging: comedi: cb_pcidas: tidy up analog input subdevice init
>    staging: comedi: cb_pcidas: rename handle_ao_interrupt()
>    staging: comedi: cb_pcidas: split ai code out of interrupt handler
>    staging: comedi: cb_pcidas: consolidate interrupt clear code
>    staging: comedi: cb_pcidas: absorb cal_enable_bits()
>    staging: comedi: cb_pcidas: remove superfluous comment
>    staging: comedi: cb_pcidas: fix cb_pcidas_ao_fifo_insn_write()
>    staging: comedi: cb_pcidas: fix cb_pcidas_ao_nofifo_insn_write()
>    staging: comedi: cb_pcidas: update MODULE_DESCRIPTION
>
>   drivers/staging/comedi/drivers/cb_pcidas.c | 1175 +++++++++++++---------------
>   1 file changed, 550 insertions(+), 625 deletions(-)
>

Thanks!

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-