[PATCH] staging: comedi: adl_pci6208: prefer using the BIT macro

Ian Abbott abbotti at mev.co.uk
Sat Oct 10 10:17:56 UTC 2015


On 09/10/15 19:01, H Hartley Sweeten wrote:
> As suggested by checkpatch.pl, use the BIT macro to define the
> register bits.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/adl_pci6208.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/adl_pci6208.c b/drivers/staging/comedi/drivers/adl_pci6208.c
> index 7ed3fd6..ad7e7c4 100644
> --- a/drivers/staging/comedi/drivers/adl_pci6208.c
> +++ b/drivers/staging/comedi/drivers/adl_pci6208.c
> @@ -41,7 +41,7 @@
>    */
>   #define PCI6208_AO_CONTROL(x)		(0x00 + (2 * (x)))
>   #define PCI6208_AO_STATUS		0x00
> -#define PCI6208_AO_STATUS_DATA_SEND	(1 << 0)
> +#define PCI6208_AO_STATUS_DATA_SEND	BIT(0)
>   #define PCI6208_DIO			0x40
>   #define PCI6208_DIO_DO_MASK		(0x0f)
>   #define PCI6208_DIO_DO_SHIFT		(0)
>

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list