[PATCH] staging: comedi: addi_apci_1032: prefer using the BIT macro

[Ian Abbott]

On 09/10/15 18:32, H Hartley Sweeten wrote:
> As suggested by checkpatch.pl, use the BIT macro to define the
> register bits.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/addi_apci_1032.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
> index b37166d..ccd1a91 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1032.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
> @@ -84,9 +84,10 @@
>   #define APCI1032_MODE2_REG		0x08
>   #define APCI1032_STATUS_REG		0x0c
>   #define APCI1032_CTRL_REG		0x10
> -#define APCI1032_CTRL_INT_OR		(0 << 1)
> -#define APCI1032_CTRL_INT_AND		(1 << 1)
> -#define APCI1032_CTRL_INT_ENA		(1 << 2)
> +#define APCI1032_CTRL_INT_MODE(x)	(((x) & 0x1) << 1)
> +#define APCI1032_CTRL_INT_OR		APCI1032_CTRL_INT_MODE(0)
> +#define APCI1032_CTRL_INT_AND		APCI1032_CTRL_INT_MODE(1)
> +#define APCI1032_CTRL_INT_ENA		BIT(2)
>
>   struct apci1032_private {
>   	unsigned long amcc_iobase;	/* base of AMCC I/O registers */
>

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-