[PATCH 00/13] staging: comedi: mf6x4: cleanup driver

[Ian Abbott]

On 07/10/15 17:37, Hartley Sweeten wrote:
> On Wednesday, October 07, 2015 2:20 AM, Ian Abbott wrote:
>> On 06/10/15 19:11, H Hartley Sweeten wrote:
>>> Fix some minor checkpatch.pl issues and tidy up this driver a bit.
>>>
>>> H Hartley Sweeten (13):
>>>     staging: comedi: mf6x4: prefer using the BIT macro
>>>     staging: comedi: mf6x4: remove unnecessary defines
>>>     staging: comedi: mf6x4: remove unnecessary whitespace
>>>     staging: comedi: mf6x4: sort the BAR1 register defines
>>>     staging: comedi: mf6x4: introduce a macro to select the AI channel
>>>     staging: comedi: mf6x4: A/D converter uses 2's complement coding
>>>     staging: comedi: mf6x4: remove unnecassary masking of digital outputs
>>>     staging: comedi: mf6x4: rename the digital input register defines
>>>     staging: comedi: mf6x4: rename remaining BAR1 register defines
>>>     staging: comedi: mf6x4: rename private data 'gpio_R'
>>>     staging: comedi: mf6x4: refactor block comment
>>>     staging: comedi: mf6x4: change type of local variable
>>>     staging: comedi: mf6x4: tidy up subdevice init
>>>
>>>    drivers/staging/comedi/drivers/mf6x4.c | 137 +++++++++++++++------------------
>>>    1 file changed, 63 insertions(+), 74 deletions(-)
>>>
>>
>> Thanks!  One thing unaccounted for is that the D/A converter also uses
>> 2's complement coding.
>>
>> Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
>
> According to the programming guide, the D/A converters use straight
> binary coding:
>
> 	0x3fff	= 9.9988V
> 	0x2000	= 0.0000V
> 	0x1fff	= -0.0012V
> 	0x0000	= -10.0000V

Yes, you're correct.  I misread it!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-