[PATCH 08/10] staging: wilc1000: rename s32Error in host_int_wait_msg_queue_idle

[Julian Calaby]

Hi Chaehyun,

On Fri, Oct 2, 2015 at 10:44 PM, Chaehyun Lim <chaehyun.lim at gmail.com> wrote:
> This patch replaces s32Error with result to avoid camelcase.
>
> Signed-off-by: Chaehyun Lim <chaehyun.lim at gmail.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index e5b7689..69a4e79 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -5344,7 +5344,7 @@ int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *wfi_drv, u8 channel)
>
>  int host_int_wait_msg_queue_idle(void)
>  {
> -       int s32Error = 0;
> +       int result = 0;
>
>         struct host_if_msg msg;
>
> @@ -5352,16 +5352,16 @@ int host_int_wait_msg_queue_idle(void)
>
>         memset(&msg, 0, sizeof(struct host_if_msg));
>         msg.id = HOST_IF_MSG_Q_IDLE;
> -       s32Error = wilc_mq_send(&gMsgQHostIF, &msg, sizeof(struct host_if_msg));
> -       if (s32Error) {
> +       result = wilc_mq_send(&gMsgQHostIF, &msg, sizeof(struct host_if_msg));
> +       if (result) {
>                 PRINT_ER("wilc mq send fail\n");
> -               s32Error = -EINVAL;
> +               result = -EINVAL;

Same comments here: Why not

return -EINVAL;

>         }
>
>         /* wait untill MSG Q is empty */
>         down(&hWaitResponse);
>
> -       return s32Error;
> +       return result;

and

return 0;

Thanks,

-- 
Julian Calaby

Email: julian.calaby at gmail.com
Profile: http://www.google.com/profiles/julian.calaby/