[PATCH 3/4] staging: wilc1000: rename index to tcp_pending_ack_idx

glen lee glen.lee at atmel.com
Fri Nov 20 01:30:17 UTC 2015



On 2015년 11월 20일 00:45, Greg KH wrote:
> On Thu, Nov 19, 2015 at 03:53:34PM +0900, glen lee wrote:
>>
>> On 2015년 11월 19일 15:23, Dan Carpenter wrote:
>>> On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote:
>>>> This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since
>>>> this name could be confused index of txq_entry_t. It is index of tcp pending
>>>> ack.
>>>>
>>>> It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da
>>>>
>>> It is just a cleanup patch and not a bugfix patch so "fix" is the wrong
>>> word here.  But the correct format for fixes tags is:
>>>
>>> Fixes: 123456789012 ('Title of patch')
>> I see, I learned another one. Thanks.
> Git can do this automatically for you:
> 	 git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"

This is helpful for me. Thanks.

regards,
glen lee

> I have an alias for this to make it easier to use frequently.
>
> greg k-h



More information about the devel mailing list