linux-4.4-rc1/drivers/staging/rts5208/sd.c:4170: bad if test ?
Sudip Mukherjee
sudipm.mukherjee at gmail.com
Thu Nov 19 04:15:40 UTC 2015
On Wed, Nov 18, 2015 at 09:31:36AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Nov 18, 2015 at 05:25:38PM +0000, David Binderman wrote:
> > Hello there Greg,
> >
> > ----------------------------------------
> > > Date: Wed, 18 Nov 2015 09:14:41 -0800
> > > From: gregkh at linuxfoundation.org
> > > To: dcb314 at hotmail.com
> > > CC: devel at driverdev.osuosl.org
> > > Subject: Re: linux-4.4-rc1/drivers/staging/rts5208/sd.c:4170: bad if test ?
> > >
> > > On Wed, Nov 18, 2015 at 08:53:51AM +0000, David Binderman wrote:
> > >> hello there,
> > >>
> > >> [linux-4.4-rc1/drivers/staging/rts5208/sd.c:4170]: (style) Expression '(X & 0x1e) != 0x3' is always true.
> > >>
> > >> Source code is
> > >>
> > >> if ((ptr[3] & 0x1E) != 0x03) {
> > >>
> > >> Suggest code rework.
> > >
> > > Great, please send a patch fixing this!
> >
> > Sorry, not possible. I can't meet the strict requirements of kernel patches,
> > due to my hotmail account messing up white space.
>
> Use hotmail as an imap server for 'git send-email' or use one of many
> other free email providers that will not damage whitespace.
David has mentioned it in bugzilla for 3.14-rc1.
(https://bugzilla.kernel.org/show_bug.cgi?id=69881)
The patch has been submitted multiple times.
https://lkml.org/lkml/2014/2/15/24
and then again on:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-May/069334.html
regards
sudip
More information about the devel
mailing list