[PATCH 00/33] staging: comedi: adv_pci_dio: cleanup driver

Ian Abbott abbotti at mev.co.uk
Wed Nov 18 18:43:38 UTC 2015


On 18/11/15 17:07, H Hartley Sweeten wrote:
> With the PCI-1760 support moved to a separate driver this one can now
> be simplified and cleaned up pretty nicely.
>
> Tidy up this driver and fix all the checkpatch.pl issues.
>
> This series applies after:
> "staging: comedi: adv_pci_dio: separate out PCI-1760 support"
>
> H Hartley Sweeten (33):
>    staging: comedi: adv_pci_dio: remove unnecessary function separation comments
>    staging: comedi: adv_pci_dio: tidy up comedi driver block comment
>    staging: comedi: adv_pci_dio: remove 'main_pci_region' boardinfo
>    staging: comedi: adv_pci_dio: post increment 'subdev' in (*auto_attach)
>    staging: comedi: adv_pci_dio: use a const pointer to the diosubd_data
>    staging: comedi: adv_pci_dio: absorb pci_dio_add_do()
>    staging: comedi: adv_pci_dio: absorb pci_dio_add_di()
>    staging: comedi: adv_pci_dio: refactor 'io_access' boardinfo
>    staging: comedi: adv_pci_dio: remove need for diosubd_data 'regs' member
>    staging: comedi: adv_pci_dio: use the diosubd_data 'addr' for di/do s->private
>    staging: comedi: adv_pci_dio: simplify the 'boardid' boardinfo
>    staging: comedi: adv_pci_dio: remove defines used for the 'timer_regbase'
>    staging: comedi: adv_pci_dio: remove defines used for the di registers
>    staging: comedi: adv_pci_dio: remove board reset during (*detach)
>    staging: comedi: adv_pci_dio: do board reset early in (*auto_attach)
>    staging: comedi: adv_pci_dio: reset digital outputs in subdevice init
>    staging: comedi: adv_pci_dio: remove defines used for the do registers
>    staging: comedi: adv_pci_dio: remove defines used for the dio (8255) registers
>    staging: comedi: adv_pci_dio: use a default case in pci_dio_reset()
>    staging: comedi: adv_pci_dio: disable channel freeze outside of switch
>    staging: comedi: adv_pci_dio: cleanup "disable and clear interrupts" comments
>    staging: comedi: adv_pci_dio: use common defines for PCI-173[036] registers
>    staging: comedi: adv_pci_dio: use common defines for PCI-1739/175[01] registers
>    staging: comedi: adv_pci_dio: cleanup PCI-1753 interrupt register defines
>    staging: comedi: adv_pci_dio: cleanup PCI-175[46] interrupt registers
>    staging: comedi: adv_pci_dio: rename PCI1752_6_CFC define
>    staging: comedi: adv_pci_dio: cleanup PCI-1762 interrupt registers
>    staging: comedi: adv_pci_dio: remove boardinfo 'cardtype'
>    staging: comedi: adv_pci_dio: move and rename enum hw_cards_id
>    staging: comedi: adv_pci_dio: move and rename the MAX_*_SUBDEV[SG] defines
>    staging: comedi: adv_pci_dio: move pci_dio_override_cardtype()
>    staging: comedi: adv_pci_dio: tidy up the comedi comment block
>    staging: comedi: adv_pci_dio: update the MODULE_DESCRIPTION
>
>   drivers/staging/comedi/drivers/adv_pci_dio.c | 707 ++++++++++-----------------
>   1 file changed, 265 insertions(+), 442 deletions(-)
>

Just a minor niggle with a comment in patch 17.  It's not worth 
reposting the whole series for that.  Can correct it later.

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list