linux-4.4-rc1/drivers/staging/rts5208/sd.c:4170: bad if test ?

David Binderman dcb314 at hotmail.com
Wed Nov 18 17:25:38 UTC 2015


Hello there Greg,

----------------------------------------
> Date: Wed, 18 Nov 2015 09:14:41 -0800
> From: gregkh at linuxfoundation.org
> To: dcb314 at hotmail.com
> CC: devel at driverdev.osuosl.org
> Subject: Re: linux-4.4-rc1/drivers/staging/rts5208/sd.c:4170: bad if test ?
>
> On Wed, Nov 18, 2015 at 08:53:51AM +0000, David Binderman wrote:
>> hello there,
>>
>> [linux-4.4-rc1/drivers/staging/rts5208/sd.c:4170]: (style) Expression '(X & 0x1e) != 0x3' is always true.
>>
>> Source code is
>>
>>   if ((ptr[3] & 0x1E) != 0x03) {
>>
>> Suggest code rework.
>
> Great, please send a patch fixing this!

Sorry, not possible. I can't meet the strict requirements of kernel patches,
due to my hotmail account messing up white space.

Maybe someone on the cc: list would be keen enough to generate a suitable patch ?

Regards

David Binderman

 		 	   		  


More information about the devel mailing list