[PATCH v2 03/23] staging: comedi: adv_pci1710: don't "reset" board when detaching

H Hartley Sweeten hsweeten at visionengravers.com
Fri Nov 13 18:11:06 UTC 2015

Currently this driver calls pci1710_reset() during the (*detach) of
the driver. That function does the following:

  1) program the control register to stop any operations
  2) clears the analog input FIFO
  3) clears any pending interrupts
  4) sets all the analog output channels to unipolar 5V range and 0V output
  5) sets all the digital outputs to 0V

Before detaching the comedi core will (*cancel) any running async commands.
This will handle 1-3 above.

Depending on the application, it might not be safe to reset the analog and
digital outputs when the driver is detached.

Remove the board reset when detaching and just use comedi_pci_detach()
directly for the driver (*detach).

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
 drivers/staging/comedi/drivers/adv_pci1710.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
index 62f9f47..e6d9db8 100644
--- a/drivers/staging/comedi/drivers/adv_pci1710.c
+++ b/drivers/staging/comedi/drivers/adv_pci1710.c
@@ -882,18 +882,11 @@ static int pci1710_auto_attach(struct comedi_device *dev,
 	return 0;
-static void pci1710_detach(struct comedi_device *dev)
-	if (dev->iobase)
-		pci1710_reset(dev);
-	comedi_pci_detach(dev);
 static struct comedi_driver adv_pci1710_driver = {
 	.driver_name	= "adv_pci1710",
 	.module		= THIS_MODULE,
 	.auto_attach	= pci1710_auto_attach,
-	.detach		= pci1710_detach,
+	.detach		= comedi_pci_detach,
 static int adv_pci1710_pci_probe(struct pci_dev *dev,

More information about the devel mailing list