[PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

[Sell, Timothy C]

> -----Original Message-----
> From: Greg KH [mailto:gregkh at linuxfoundation.org]
> Sent: Thursday, November 12, 2015 4:28 PM
> To: Sell, Timothy C
> Cc: Romer, Benjamin M; driverdev-devel at linuxdriverproject.org; *S-Par-
> Maintainer
> Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting
> for device data struct
> 
> On Thu, Nov 12, 2015 at 09:21:14PM +0000, Sell, Timothy C wrote:
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh at linuxfoundation.org]
> > > Sent: Thursday, November 12, 2015 4:12 PM
> > > To: Sell, Timothy C
> > > Cc: Romer, Benjamin M; driverdev-devel at linuxdriverproject.org; *S-Par-
> > > Maintainer
> > > Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref ref-counting
> > > for device data struct
> > >
> > > On Thu, Nov 12, 2015 at 09:07:24PM +0000, Sell, Timothy C wrote:
> > > > What should I do with this patchset?
> > >
> > > What patchset?
> >
> > "[PATCH 0/9] staging: unisys: visorinput fixes and enhancements",
> > submitted by Ben Romer Fri 10/16/2015 @ 10:07 AM.
> 
> I don't see this in my "to-review" queue at all, sorry.  If this was
> some old patchset, you are going to have to resend as my memory is
> totally gone (remember, I get 1000 emails a day, and my to-review mbox
> is right now 1637 emails to process once the merge window opens up...)
> 
> > > > Some history: it was fixing this one little line in
> > > > drivers/staging/unisys/visorinput/Kconfig that triggered this patchset:
> > > >
> > > > 	depends on UNISYSSPAR && UNISYS_VISORBUS && FB
> > > >
> > > > Adding "INPUT" was easy, but it turned out that removing "FB" was
> hard.
> > > ;-(
> > > > Removing FB is at the crux of this patchset.
> > > >
> > > > Rarely a week passes where I don't get a complaint from the
> > > > community about the fact that I need to add "INPUT" to that line to fix
> > > > errors when building with randconfig.
> > >
> > > Then submit a patch that fixes that! :)
> >
> > That's what I did, originally.  But you told me I had to get rid of the FB
> > requirement.  So  that's why we submitted
> > "[PATCH 0/9] staging: unisys: visorinput fixes and enhancements", which
> > includes all the stuff we needed to get rid of FB as well as the last
> > patch in the series, which adds INPUT.
> > Ben Romer actually submitted the patchset Fri 10/16/2015 @ 10:07 AM.
> 
> It's not in my queue, so I have no idea what happened to it.  Did I
> apply it?  Reject it?  something else?
> 
> thanks,
> 
> greg k-h

We were bantering back-and-forth about a lock, but the thread stopped
without a conclusion.  You definitely did NOT apply it.

No problem.  We'll just re-submit the set.

Thanks.

Tim Sell